diff --git a/src/context.c b/src/context.c index 1e28911..b283fc4 100644 --- a/src/context.c +++ b/src/context.c @@ -37,7 +37,7 @@ struct xkb_context { darray(char *) includes; /* xkbcomp needs to assign sequential IDs to XkbFile's it creates. */ - int file_id; + unsigned file_id; struct atom_table *atom_table; }; @@ -144,7 +144,7 @@ xkb_context_include_path_get(struct xkb_context *ctx, unsigned int idx) return darray_item(ctx->includes, idx); } -int +unsigned xkb_context_take_file_id(struct xkb_context *ctx) { return ctx->file_id++; diff --git a/src/xkb-priv.h b/src/xkb-priv.h index bed35b1..b58ecc1 100644 --- a/src/xkb-priv.h +++ b/src/xkb-priv.h @@ -453,7 +453,7 @@ xkb_map_new_from_kccgst(struct xkb_context *ctx, const struct xkb_component_names *kccgst, enum xkb_map_compile_flags flags); -extern int +extern unsigned xkb_context_take_file_id(struct xkb_context *ctx); bool diff --git a/src/xkbcomp/alias.c b/src/xkbcomp/alias.c index c169656..3f09afe 100644 --- a/src/xkbcomp/alias.c +++ b/src/xkbcomp/alias.c @@ -32,7 +32,7 @@ HandleCollision(AliasInfo * old, AliasInfo * new) { if (strncmp(new->real, old->real, XkbKeyNameLength) == 0) { - if (((new->def.fileID == old->def.fileID) && (warningLevel > 0)) || + if (((new->def.file_id == old->def.file_id) && (warningLevel > 0)) || (warningLevel > 9)) { WARN("Alias of %s for %s declared more than once\n", @@ -53,7 +53,7 @@ HandleCollision(AliasInfo * old, AliasInfo * new) use = new->real; ignore = old->real; } - if (((old->def.fileID == new->def.fileID) && (warningLevel > 0)) || + if (((old->def.file_id == new->def.file_id) && (warningLevel > 0)) || (warningLevel > 9)) { WARN("Multiple definitions for alias %s\n", @@ -64,7 +64,7 @@ HandleCollision(AliasInfo * old, AliasInfo * new) if (use != old->real) memcpy(old->real, use, XkbKeyNameLength); } - old->def.fileID = new->def.fileID; + old->def.file_id = new->def.file_id; old->def.merge = new->def.merge; } @@ -74,7 +74,7 @@ InitAliasInfo(AliasInfo * info, { memset(info, 0, sizeof(AliasInfo)); info->def.merge = merge; - info->def.fileID = file_id; + info->def.file_id = file_id; strncpy(info->alias, alias, XkbKeyNameLength); strncpy(info->real, real, XkbKeyNameLength); } @@ -101,7 +101,7 @@ HandleAliasDef(KeyAliasDef * def, WSGO("Allocation failure in HandleAliasDef\n"); return false; } - info->def.fileID = file_id; + info->def.file_id = file_id; info->def.merge = merge; info->def.next = (CommonInfo *) * info_in; memcpy(info->alias, def->alias, XkbKeyNameLength); @@ -140,7 +140,7 @@ MergeAliases(AliasInfo ** into, AliasInfo ** merge, unsigned how_merge) def.merge = how_merge; memcpy(def.alias, tmp->alias, XkbKeyNameLength); memcpy(def.real, tmp->real, XkbKeyNameLength); - if (!HandleAliasDef(&def, def.merge, tmp->def.fileID, into)) + if (!HandleAliasDef(&def, def.merge, tmp->def.file_id, into)) return false; } return true; diff --git a/src/xkbcomp/compat.c b/src/xkbcomp/compat.c index 99ed570..758014b 100644 --- a/src/xkbcomp/compat.c +++ b/src/xkbcomp/compat.c @@ -44,7 +44,7 @@ typedef struct _SymInterpInfo typedef struct _GroupCompatInfo { - unsigned char fileID; + unsigned file_id; unsigned char merge; bool defined; unsigned char real_mods; @@ -54,7 +54,7 @@ typedef struct _GroupCompatInfo typedef struct _CompatInfo { char *name; - unsigned fileID; + unsigned file_id; int errorCount; int nInterps; SymInterpInfo *interps; @@ -96,18 +96,18 @@ siText(SymInterpInfo * si, CompatInfo * info) } static void -InitCompatInfo(CompatInfo *info, struct xkb_keymap *keymap) +InitCompatInfo(CompatInfo *info, struct xkb_keymap *keymap, unsigned file_id) { unsigned int i; info->keymap = keymap; info->name = NULL; - info->fileID = 0; + info->file_id = file_id; info->errorCount = 0; info->nInterps = 0; info->interps = NULL; info->act = NULL; - info->dflt.defs.fileID = info->fileID; + info->dflt.defs.file_id = file_id; info->dflt.defs.defined = 0; info->dflt.defs.merge = MERGE_OVERRIDE; info->dflt.interp.flags = 0; @@ -116,7 +116,7 @@ InitCompatInfo(CompatInfo *info, struct xkb_keymap *keymap) for (i = 0; i < sizeof(info->dflt.interp.act.any.data); i++) info->dflt.interp.act.any.data[i] = 0; ClearIndicatorMapInfo(keymap->ctx, &info->ledDflt); - info->ledDflt.defs.fileID = info->fileID; + info->ledDflt.defs.file_id = file_id; info->ledDflt.defs.defined = 0; info->ledDflt.defs.merge = MERGE_OVERRIDE; memset(&info->groupCompat[0], 0, @@ -200,7 +200,7 @@ AddInterp(CompatInfo * info, SymInterpInfo * new) if (new->defs.merge == MERGE_REPLACE) { SymInterpInfo *next = (SymInterpInfo *) old->defs.next; - if (((old->defs.fileID == new->defs.fileID) + if (((old->defs.file_id == new->defs.file_id) && (warningLevel > 0)) || (warningLevel > 9)) { WARN("Multiple definitions for \"%s\"\n", siText(new, info)); @@ -266,7 +266,7 @@ AddGroupCompat(CompatInfo * info, unsigned group, GroupCompatInfo * newGC) { return true; } - if (((gc->fileID == newGC->fileID) && (warningLevel > 0)) + if (((gc->file_id == newGC->file_id) && (warningLevel > 0)) || (warningLevel > 9)) { WARN("Compat map for group %d redefined\n", group + 1); @@ -407,12 +407,9 @@ HandleIncludeCompatMap(IncludeStmt *stmt, struct xkb_keymap *keymap, else if (ProcessIncludeFile(keymap->ctx, stmt, FILE_TYPE_COMPAT, &rtrn, &newMerge)) { - InitCompatInfo(&included, keymap); - included.fileID = rtrn->id; + InitCompatInfo(&included, keymap, rtrn->id); included.dflt = info->dflt; - included.dflt.defs.fileID = rtrn->id; included.dflt.defs.merge = newMerge; - included.ledDflt.defs.fileID = rtrn->id; included.ledDflt.defs.merge = newMerge; included.act = info->act; HandleCompatMapFile(rtrn, keymap, MERGE_OVERRIDE, &included); @@ -448,12 +445,12 @@ HandleIncludeCompatMap(IncludeStmt *stmt, struct xkb_keymap *keymap, else if (ProcessIncludeFile(keymap->ctx, next, FILE_TYPE_COMPAT, &rtrn, &op)) { - InitCompatInfo(&next_incl, keymap); - next_incl.fileID = rtrn->id; + InitCompatInfo(&next_incl, keymap, rtrn->id); + next_incl.file_id = rtrn->id; next_incl.dflt = info->dflt; - next_incl.dflt.defs.fileID = rtrn->id; + next_incl.dflt.defs.file_id = rtrn->id; next_incl.dflt.defs.merge = op; - next_incl.ledDflt.defs.fileID = rtrn->id; + next_incl.ledDflt.defs.file_id = rtrn->id; next_incl.ledDflt.defs.merge = op; next_incl.act = info->act; HandleCompatMapFile(rtrn, keymap, MERGE_OVERRIDE, &next_incl); @@ -678,7 +675,7 @@ HandleGroupCompatDef(GroupCompatDef *def, struct xkb_keymap *keymap, def->group); return false; } - tmp.fileID = info->fileID; + tmp.file_id = info->file_id; tmp.merge = merge; if (!ExprResolveVModMask(def->def, &val, keymap)) { @@ -785,7 +782,7 @@ CompileCompatMap(XkbFile *file, struct xkb_keymap *keymap, enum merge_mode merge CompatInfo info; GroupCompatInfo *gcm; - InitCompatInfo(&info, keymap); + InitCompatInfo(&info, keymap, file->id); info.dflt.defs.merge = merge; info.ledDflt.defs.merge = merge; @@ -817,7 +814,7 @@ CompileCompatMap(XkbFile *file, struct xkb_keymap *keymap, enum merge_mode merge } for (i = 0, gcm = &info.groupCompat[0]; i < XkbNumKbdGroups; i++, gcm++) { - if ((gcm->fileID != 0) || (gcm->real_mods != 0) || (gcm->vmods != 0)) { + if ((gcm->file_id != 0) || (gcm->real_mods != 0) || (gcm->vmods != 0)) { keymap->compat->groups[i].mask = gcm->real_mods; keymap->compat->groups[i].real_mods = gcm->real_mods; keymap->compat->groups[i].vmods = gcm->vmods; diff --git a/src/xkbcomp/indicators.c b/src/xkbcomp/indicators.c index 41b3649..060ed46 100644 --- a/src/xkbcomp/indicators.c +++ b/src/xkbcomp/indicators.c @@ -74,7 +74,7 @@ AddIndicatorMap(struct xkb_keymap *keymap, LEDInfo *oldLEDs, LEDInfo *new) if (new->defs.merge == MERGE_REPLACE) { CommonInfo *next = old->defs.next; - if (((old->defs.fileID == new->defs.fileID) + if (((old->defs.file_id == new->defs.file_id) && (warningLevel > 0)) || (warningLevel > 9)) { WARN("Map for indicator %s redefined\n", diff --git a/src/xkbcomp/keycodes.c b/src/xkbcomp/keycodes.c index 449825b..8751021 100644 --- a/src/xkbcomp/keycodes.c +++ b/src/xkbcomp/keycodes.c @@ -63,7 +63,7 @@ typedef struct _KeyNamesInfo { char *name; /* e.g. evdev+aliases(qwerty) */ int errorCount; - unsigned fileID; + unsigned file_id; enum merge_mode merge; xkb_keycode_t computedMin; /* lowest keycode stored */ xkb_keycode_t computedMax; /* highest keycode stored */ @@ -93,7 +93,7 @@ InitIndicatorNameInfo(IndicatorNameInfo * ii, KeyNamesInfo * info) { ii->defs.defined = 0; ii->defs.merge = info->merge; - ii->defs.fileID = info->fileID; + ii->defs.file_id = info->file_id; ii->defs.next = NULL; ii->ndx = 0; ii->name = XKB_ATOM_NONE; @@ -163,7 +163,7 @@ AddIndicatorName(KeyNamesInfo *info, struct xkb_keymap *keymap, enum merge_mode old = FindIndicatorByName(info, new->name); if (old) { - if (((old->defs.fileID == new->defs.fileID) && (warningLevel > 0)) + if (((old->defs.file_id == new->defs.file_id) && (warningLevel > 0)) || (warningLevel > 9)) { WARN("Multiple indicators named %s\n", @@ -216,7 +216,7 @@ AddIndicatorName(KeyNamesInfo *info, struct xkb_keymap *keymap, enum merge_mode old = FindIndicatorByIndex(info, new->ndx); if (old) { - if (((old->defs.fileID == new->defs.fileID) && (warningLevel > 0)) + if (((old->defs.file_id == new->defs.file_id) && (warningLevel > 0)) || (warningLevel > 9)) { WARN("Multiple names for indicator %d\n", new->ndx); @@ -286,11 +286,12 @@ ClearKeyNamesInfo(KeyNamesInfo * info) } static void -InitKeyNamesInfo(KeyNamesInfo * info) +InitKeyNamesInfo(KeyNamesInfo * info, unsigned file_id) { info->name = NULL; info->leds = NULL; info->aliases = NULL; + info->file_id = file_id; darray_init(info->names); darray_init(info->files); ClearKeyNamesInfo(info); @@ -316,8 +317,8 @@ FindKeyByLong(KeyNamesInfo * info, unsigned long name) */ static bool AddKeyName(KeyNamesInfo * info, - xkb_keycode_t kc, - char *name, enum merge_mode merge, unsigned fileID, bool reportCollisions) + xkb_keycode_t kc, char *name, enum merge_mode merge, + unsigned file_id, bool reportCollisions) { xkb_keycode_t old; unsigned long lval; @@ -334,7 +335,7 @@ AddKeyName(KeyNamesInfo * info, { reportCollisions = (warningLevel > 7 || (warningLevel > 0 && - fileID == darray_item(info->files, kc))); + file_id == darray_item(info->files, kc))); } if (darray_item(info->names, kc) != 0) @@ -394,7 +395,7 @@ AddKeyName(KeyNamesInfo * info, } } darray_item(info->names, kc) = lval; - darray_item(info->files, kc) = fileID; + darray_item(info->files, kc) = file_id; return true; } @@ -426,7 +427,7 @@ MergeIncludedKeycodes(KeyNamesInfo *into, struct xkb_keymap *keymap, continue; LongToKeyName(darray_item(from->names, i), buf); buf[4] = '\0'; - if (!AddKeyName(into, i, buf, merge, from->fileID, false)) + if (!AddKeyName(into, i, buf, merge, from->file_id, false)) into->errorCount++; } if (from->leds) @@ -492,7 +493,7 @@ HandleIncludeKeycodes(IncludeStmt *stmt, struct xkb_keymap *keymap, else if (ProcessIncludeFile(keymap->ctx, stmt, FILE_TYPE_KEYCODES, &rtrn, &newMerge)) { - InitKeyNamesInfo(&included); + InitKeyNamesInfo(&included, rtrn->id); HandleKeycodesFile(rtrn, keymap, MERGE_OVERRIDE, &included); if (stmt->stmt != NULL) { @@ -525,7 +526,7 @@ HandleIncludeKeycodes(IncludeStmt *stmt, struct xkb_keymap *keymap, else if (ProcessIncludeFile(keymap->ctx, next, FILE_TYPE_KEYCODES, &rtrn, &op)) { - InitKeyNamesInfo(&next_incl); + InitKeyNamesInfo(&next_incl, rtrn->id); HandleKeycodesFile(rtrn, keymap, MERGE_OVERRIDE, &next_incl); MergeIncludedKeycodes(&included, keymap, &next_incl, op); ClearKeyNamesInfo(&next_incl); @@ -572,7 +573,7 @@ HandleKeycodeDef(KeycodeDef *stmt, enum merge_mode merge, KeyNamesInfo *info) else merge = stmt->merge; } - return AddKeyName(info, stmt->value, stmt->name, merge, info->fileID, + return AddKeyName(info, stmt->value, stmt->name, merge, info->file_id, true); } @@ -745,7 +746,7 @@ HandleKeycodesFile(XkbFile *file, struct xkb_keymap *keymap, info->errorCount++; break; case StmtKeyAliasDef: /* e.g. alias