diff --git a/src/xkbcomp/action.c b/src/xkbcomp/action.c index e5632f3..22252b9 100644 --- a/src/xkbcomp/action.c +++ b/src/xkbcomp/action.c @@ -310,7 +310,7 @@ HandleSetLatchMods(struct xkb_keymap *keymap, struct xkb_any_action *action, if (CheckModifierField(keymap, action->type, value, &t1, &t2)) { act->flags = t1; act->real_mods = act->mask = (t2 & 0xff); - act->vmods = (t2 >> 8) & 0xffff; + act->vmods = (t2 >> XkbNumModifiers) & 0xffff; return true; } return false; @@ -335,7 +335,7 @@ HandleLockMods(struct xkb_keymap *keymap, struct xkb_any_action *action, if (CheckModifierField(keymap, action->type, value, &t1, &t2)) { act->flags = t1; act->real_mods = act->mask = (t2 & 0xff); - act->vmods = (t2 >> 8) & 0xffff; + act->vmods = (t2 >> XkbNumModifiers) & 0xffff; return true; } return false; @@ -659,7 +659,7 @@ HandleISOLock(struct xkb_keymap *keymap, struct xkb_any_action *action, act->flags = flags & (~XkbSA_ISODfltIsGroup); act->real_mods = mods & 0xff; - act->vmods = (mods >> 8) & 0xff; + act->vmods = (mods >> XkbNumModifiers) & 0xffff; return true; } else if (field == F_Group) { @@ -937,7 +937,7 @@ HandleRedirectKey(struct xkb_keymap *keymap, struct xkb_any_action *action, else act->mods &= ~(t2 & 0xff); - t2 = (t2 >> 8) & 0xffff; + t2 = (t2 >> XkbNumModifiers) & 0xffff; act->vmods_mask |= t2; if (field == F_Modifiers) act->vmods |= t2; diff --git a/src/xkbcomp/compat.c b/src/xkbcomp/compat.c index 2761221..064a7fe 100644 --- a/src/xkbcomp/compat.c +++ b/src/xkbcomp/compat.c @@ -767,7 +767,7 @@ SetIndicatorMapField(CompatInfo *info, LEDInfo *led, return ReportIndicatorBadType(info, led, field, "modifier mask"); led->real_mods = mask & 0xff; - led->vmods = (mask >> 8) & 0xff; + led->vmods = (mask >> XkbNumModifiers) & 0xffff; led->defined |= LED_FIELD_MODS; } else if (istreq(field, "groups")) { @@ -998,7 +998,7 @@ HandleGroupCompatDef(CompatInfo *info, GroupCompatDef *def, } tmp.real_mods = mask & 0xff; - tmp.vmods = (mask >> 8) & 0xffff; + tmp.vmods = (mask >> XkbNumModifiers) & 0xffff; tmp.defined = true; return AddGroupCompat(info, def->group - 1, &tmp); } diff --git a/src/xkbcomp/keytypes.c b/src/xkbcomp/keytypes.c index 1eeae5a..f25a1f5 100644 --- a/src/xkbcomp/keytypes.c +++ b/src/xkbcomp/keytypes.c @@ -466,7 +466,7 @@ SetModifiers(KeyTypesInfo *info, KeyTypeInfo *type, ExprDef *arrayNdx, } mods = mask & 0xff; /* core mods */ - vmods = (mask >> 8) & 0xffff; /* xkb virtual mods */ + vmods = (mask >> XkbNumModifiers) & 0xffff; /* xkb virtual mods */ if (type->defined & TYPE_FIELD_MASK) { log_warn(info->keymap->ctx, @@ -644,8 +644,8 @@ SetMapEntry(KeyTypesInfo *info, KeyTypeInfo *type, ExprDef *arrayNdx, if (!ExprResolveVModMask(info->keymap, arrayNdx, &mask)) return ReportTypeBadType(info, type, "map entry", "modifier mask"); - entry.mods.real_mods = mask & 0xff; /* modifiers < 512 */ - entry.mods.vmods = (mask >> 8) & 0xffff; /* modifiers > 512 */ + entry.mods.real_mods = mask & 0xff; + entry.mods.vmods = (mask >> XkbNumModifiers) & 0xffff; if ((entry.mods.real_mods & (~type->mask)) || (entry.mods.vmods & (~type->vmask))) { @@ -686,7 +686,7 @@ SetPreserve(KeyTypesInfo *info, KeyTypeInfo *type, ExprDef *arrayNdx, "modifier mask"); new.indexMods = mask & 0xff; - new.indexVMods = (mask >> 8) & 0xffff; + new.indexVMods = (mask >> XkbNumModifiers) & 0xffff; if ((new.indexMods & (~type->mask)) || (new.indexVMods & (~type->vmask))) { @@ -711,7 +711,7 @@ SetPreserve(KeyTypesInfo *info, KeyTypeInfo *type, ExprDef *arrayNdx, } new.preMods = mask & 0xff; - new.preVMods = (mask >> 16) & 0xffff; + new.preVMods = (mask >> XkbNumModifiers) & 0xffff; if ((new.preMods & (~new.indexMods)) || (new.preVMods & (~new.indexVMods))) { diff --git a/src/xkbcomp/symbols.c b/src/xkbcomp/symbols.c index ea4fb11..62c9fd5 100644 --- a/src/xkbcomp/symbols.c +++ b/src/xkbcomp/symbols.c @@ -81,7 +81,7 @@ typedef struct _KeyInfo { xkb_atom_t types[XkbNumKbdGroups]; enum key_repeat repeat; - unsigned short vmodmap; + xkb_mod_mask_t vmodmap; xkb_atom_t dfltType; uint8_t out_of_range_group_action; @@ -1040,7 +1040,7 @@ SetSymbolsField(SymbolsInfo *info, KeyInfo *keyi, const char *field, ok = ExprResolveVModMask(info->keymap, value, &mask); if (ok) { - keyi->vmodmap = (mask >> 8); + keyi->vmodmap = (mask >> XkbNumModifiers) & 0xffff; keyi->defined |= KEY_FIELD_VMODMAP; } else {