From 01248a99c8eac994cf669f77753ba27ed2e2b25a Mon Sep 17 00:00:00 2001 From: Susko3 Date: Wed, 6 Mar 2024 20:37:39 +0100 Subject: [PATCH] Add `default: break;` to switches on SDL_Event::type This is just a nice-to-have, as `SDL_Event::type` in an `Uint32`, so there are no compiler errors about not handling all `SDL_EventType` enum values. --- src/test/SDL_test_common.c | 2 ++ test/testcamera.c | 2 ++ test/testhittesting.c | 2 ++ test/testhotplug.c | 2 ++ test/testoffscreen.c | 2 ++ test/testoverlay.c | 2 ++ test/testrelative.c | 2 ++ test/teststreaming.c | 2 ++ 8 files changed, 16 insertions(+) diff --git a/src/test/SDL_test_common.c b/src/test/SDL_test_common.c index 42d45c409..4acc40b66 100644 --- a/src/test/SDL_test_common.c +++ b/src/test/SDL_test_common.c @@ -2422,6 +2422,8 @@ int SDLTest_CommonEventMainCallbacks(SDLTest_CommonState *state, const SDL_Event } case SDL_EVENT_QUIT: return 1; + default: + break; } return 0; /* keep going */ diff --git a/test/testcamera.c b/test/testcamera.c index d6e971bb8..51ba1d2aa 100644 --- a/test/testcamera.c +++ b/test/testcamera.c @@ -202,6 +202,8 @@ int SDL_AppEvent(const SDL_Event *event) SDL_Log("Camera denied!"); SDL_ShowSimpleMessageBox(SDL_MESSAGEBOX_ERROR, "Camera permission denied!", "User denied access to the camera!", window); return -1; + default: + break; } return SDLTest_CommonEventMainCallbacks(state, event); diff --git a/test/testhittesting.c b/test/testhittesting.c index e65c2fa47..4de043ad1 100644 --- a/test/testhittesting.c +++ b/test/testhittesting.c @@ -153,6 +153,8 @@ int main(int argc, char **argv) case SDL_EVENT_QUIT: done = 1; break; + default: + break; } } diff --git a/test/testhotplug.c b/test/testhotplug.c index 3d923d376..076177446 100644 --- a/test/testhotplug.c +++ b/test/testhotplug.c @@ -155,6 +155,8 @@ int main(int argc, char *argv[]) case SDL_EVENT_JOYSTICK_BUTTON_UP: SDL_Log("Button Release: %d\n", event.jbutton.button); break; + default: + break; } } } diff --git a/test/testoffscreen.c b/test/testoffscreen.c index 085071a74..59696d693 100644 --- a/test/testoffscreen.c +++ b/test/testoffscreen.c @@ -74,6 +74,8 @@ static void loop(void) case SDL_EVENT_QUIT: done = SDL_TRUE; break; + default: + break; } } diff --git a/test/testoverlay.c b/test/testoverlay.c index 96e4c27ad..ae5cacdd8 100644 --- a/test/testoverlay.c +++ b/test/testoverlay.c @@ -282,6 +282,8 @@ static void loop(void) if (event.key.keysym.sym != SDLK_ESCAPE) { break; } + default: + break; } } diff --git a/test/testrelative.c b/test/testrelative.c index 40320d480..01612ac28 100644 --- a/test/testrelative.c +++ b/test/testrelative.c @@ -47,6 +47,8 @@ static void loop(void) mouseX += event.motion.xrel; mouseY += event.motion.yrel; } break; + default: + break; } } for (i = 0; i < state->num_windows; ++i) { diff --git a/test/teststreaming.c b/test/teststreaming.c index 2c9ee7f4f..cd1032779 100644 --- a/test/teststreaming.c +++ b/test/teststreaming.c @@ -114,6 +114,8 @@ static void loop(void) case SDL_EVENT_QUIT: done = SDL_TRUE; break; + default: + break; } }