geemili
/
SDL
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed bug 3134 - CalculateXRandRRefreshRate() returns incorrect refresh rate due to floating point truncation. 

Michael

In SDL_x11modes.c the CalculateXRandRRefreshRate() function performs integer math on values that may return fractional results. This causes a value that would be calculated as 59.99972... to be returned as 59. In Linux the xrandr command returns 60Hz for this particular display mode yet SDL returns 59Hz.

I suggest this function be updated to correctly round the result of the calculation instead of truncating the result.
Sam Lantinga 2016-10-01 14:16:04 -07:00
parent 7543092add
commit 0250eb3c4f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/video/x11/SDL_x11modes.c
View File

@ -264,8 +264,8 @@ CheckXRandR(Display * display, int *major, int *minor)
static int static int
CalculateXRandRRefreshRate(const XRRModeInfo *info) CalculateXRandRRefreshRate(const XRRModeInfo *info)
{ {
return (info->hTotal return (info->hTotal && info->vTotal) ?
&& info->vTotal) ? (info->dotClock / (info->hTotal * info->vTotal)) : 0; round(((double)info->dotClock / (double)(info->hTotal * info->vTotal))) : 0;
} }
static SDL_bool static SDL_bool