From 2a42952281459d8d2b173f154227c103276016cf Mon Sep 17 00:00:00 2001 From: "Ryan C. Gordon" Date: Wed, 27 Apr 2022 08:06:28 -0400 Subject: [PATCH] log: Don't stack-allocate the message buffer. It's 4 kilobytes, so I could see this failing if you have a thread with a tiny stack that unexpectedly logs something. --- src/SDL_log.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/SDL_log.c b/src/SDL_log.c index 4f820ffa7..dfbaca499 100644 --- a/src/SDL_log.c +++ b/src/SDL_log.c @@ -282,8 +282,7 @@ SDL_LogMessageV(int category, SDL_LogPriority priority, const char *fmt, va_list return; } - /* !!! FIXME: why not just "char message[SDL_MAX_LOG_MESSAGE];" ? */ - message = SDL_stack_alloc(char, SDL_MAX_LOG_MESSAGE); + message = (char *) SDL_malloc(SDL_MAX_LOG_MESSAGE); if (!message) { return; } @@ -300,7 +299,7 @@ SDL_LogMessageV(int category, SDL_LogPriority priority, const char *fmt, va_list } SDL_log_function(SDL_log_userdata, category, priority, message); - SDL_stack_free(message); + SDL_free(message); } #if defined(__WIN32__) && !defined(HAVE_STDIO_H) && !defined(__WINRT__)