geemili
/
SDL
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed bug 3723 - Possible double free in kmsdrm init code on certain errors 

Simon Hug

KMSDRM_VideoInit allocates and frees some connectors and encoders but doesn't set the pointer to NULL after freeing. The cleanup code at the end may free one of those garbage pointer should an error happen in the initialization.
Sam Lantinga 2017-08-11 10:05:45 -07:00
parent d0b46f1bea
commit a05522a089
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/video/kmsdrm/SDL_kmsdrmvideo.c
View File

@ -325,6 +325,7 @@ KMSDRM_VideoInit(_THIS)
} }
KMSDRM_drmModeFreeConnector(connector); KMSDRM_drmModeFreeConnector(connector);
connector = NULL;
} }
if (i == resources->count_connectors) { if (i == resources->count_connectors) {
@ -345,6 +346,7 @@ KMSDRM_VideoInit(_THIS)
} }
KMSDRM_drmModeFreeEncoder(encoder); KMSDRM_drmModeFreeEncoder(encoder);
encoder = NULL;
} }
if (i == resources->count_encoders) { if (i == resources->count_encoders) {