From c9b097e659e6eeb7c65921b2e96cc55a84feebb9 Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Thu, 19 Nov 2020 13:31:16 -0800 Subject: [PATCH] Clarify the meaning of the rumble enable bits for the PS5 controller --- src/joystick/hidapi/SDL_hidapi_ps5.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/joystick/hidapi/SDL_hidapi_ps5.c b/src/joystick/hidapi/SDL_hidapi_ps5.c index 61dedf70b..afef4ef7e 100644 --- a/src/joystick/hidapi/SDL_hidapi_ps5.c +++ b/src/joystick/hidapi/SDL_hidapi_ps5.c @@ -360,7 +360,8 @@ HIDAPI_DriverPS5_UpdateEffects(SDL_HIDAPI_Device *device, EDS5Effect effect) effects = (DS5EffectsState_t *)&data[offset]; if (ctx->rumble_left || ctx->rumble_right) { - effects->ucEnableBits1 |= 0x03; /* Enable left/right rumble */ + effects->ucEnableBits1 |= 0x01; /* Enable rumble emulation */ + effects->ucEnableBits1 |= 0x02; /* Disable audio haptics */ /* Shift to reduce effective rumble strength to match Xbox controllers */ effects->ucRumbleLeft = ctx->rumble_left >> 2;