From e84fc5a368544a091660d340d5cae38bbd571ec7 Mon Sep 17 00:00:00 2001 From: "Ryan C. Gordon" Date: Wed, 19 Mar 2014 18:25:21 -0400 Subject: [PATCH] Static analysis fix: division by zero. --- src/render/SDL_yuv_sw.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/render/SDL_yuv_sw.c b/src/render/SDL_yuv_sw.c index af685b9d4..4bd1856f4 100644 --- a/src/render/SDL_yuv_sw.c +++ b/src/render/SDL_yuv_sw.c @@ -1274,11 +1274,16 @@ SDL_SW_CopyYUVToRGB(SDL_SW_YUVTexture * swdata, const SDL_Rect * srcrect, Uint32 target_format, int w, int h, void *pixels, int pitch) { + const int targetbpp = SDL_BYTESPERPIXEL(target_format); int stretch; int scale_2x; Uint8 *lum, *Cr, *Cb; int mod; + if (targetbpp == 0) { + return SDL_SetError("Invalid target pixel format"); + } + /* Make sure we're set up to display in the desired format */ if (target_format != swdata->target_format) { if (SDL_SW_SetupYUVDisplay(swdata, target_format) < 0) { @@ -1366,7 +1371,7 @@ SDL_SW_CopyYUVToRGB(SDL_SW_YUVTexture * swdata, const SDL_Rect * srcrect, default: return SDL_SetError("Unsupported YUV format in copy"); } - mod = (pitch / SDL_BYTESPERPIXEL(target_format)); + mod = (pitch / targetbpp); if (scale_2x) { mod -= (swdata->w * 2);