bc9888c9b5
Based on a patch by Jochen Schäfer <josch1710@live.de> :
The problem is, that in the initialization code uses the same structure for
desktop_mode and current_mode. See SDL_os2video.c:OS2_VideoInit():
stSDLDisplay.desktop_mode = stSDLDisplayMode;
stSDLDisplay.current_mode = stSDLDisplayMode;
...
stSDLDisplayMode.driverdata = pDisplayData;
Then, if you call GetDisplayModes, current_mode will added to the modes
list, with the same driverdata pointer to desktop_mode.
SDL_AddDisplayMode( display, &display->current_mode );
When VideoQuit gets called, first the modes list gets freed including the
driverdata, the desktop_mode gets freed. See SDL_video.c:SDL_VideoQuit():
for (j = display->num_display_modes; j--;) {
SDL_free(display->display_modes[j].driverdata);
display->display_modes[j].driverdata = NULL;
}
SDL_free(display->display_modes);
display->display_modes = NULL;
SDL_free(display->desktop_mode.driverdata);
display->desktop_mode.driverdata = NULL;
So, the display_modes[j].driverdata gets freed, but desktop_mode->driverdata
points to the same memory, but is not NULL'ed. When desktop_mode->driverdata
gets freed the memory is already freed, and libcx crashes the application on
SDL_Quit.
|
||
|---|---|---|
| .github | ||
| VisualC | ||
| VisualC-WinRT | ||
| Xcode | ||
| Xcode-iOS | ||
| acinclude | ||
| android-project | ||
| android-project-ant | ||
| build-scripts | ||
| cmake | ||
| debian | ||
| docs | ||
| include | ||
| src | ||
| test | ||
| visualtest | ||
| wayland-protocols | ||
| .gitignore | ||
| Android.mk | ||
| BUGS.txt | ||
| CMakeLists.txt | ||
| CREDITS.txt | ||
| INSTALL.txt | ||
| LICENSE.txt | ||
| Makefile.in | ||
| Makefile.minimal | ||
| Makefile.os2 | ||
| Makefile.pandora | ||
| Makefile.psp | ||
| Makefile.wiz | ||
| README-SDL.txt | ||
| README.md | ||
| SDL2.spec.in | ||
| SDL2Config.cmake | ||
| TODO.txt | ||
| WhatsNew.txt | ||
| autogen.sh | ||
| cmake_uninstall.cmake.in | ||
| configure | ||
| configure.ac | ||
| sdl2-config-version.cmake.in | ||
| sdl2-config.cmake.in | ||
| sdl2-config.in | ||
| sdl2.m4 | ||
| sdl2.pc.in | ||
README.md
Simple DirectMedia Layer (SDL) Version 2.0
Simple DirectMedia Layer is a cross-platform development library designed to provide low level access to audio, keyboard, mouse, joystick, and graphics hardware via OpenGL and Direct3D. It is used by video playback software, emulators, and popular games including Valve's award winning catalog and many Humble Bundle games.
More extensive documentation is available in the docs directory, starting with README.md
Enjoy!
Sam Lantinga (slouken@libsdl.org)