drm/linux-core/intel_fb.c

/*
 * Copyright © 2007 David Airlie
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *     David Airlie
 */
    /*
     *  Modularization
     */

#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/errno.h>
#include <linux/string.h>
#include <linux/mm.h>
#include <linux/tty.h>
#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/fb.h>
#include <linux/init.h>

#include "drmP.h"
#include "drm.h"
#include "drm_crtc.h"
#include "intel_drv.h"
#include "i915_drm.h"
#include "i915_drv.h"

struct intelfb_par {
	struct drm_device *dev;
	struct drm_display_mode *our_mode;
	struct intel_framebuffer *intel_fb;
	int crtc_count;
	struct list_head mode_set_list;
};
/*
static int
var_to_refresh(const struct fb_var_screeninfo *var)
{
	int xtot = var->xres + var->left_margin + var->right_margin +
		var->hsync_len;
	int ytot = var->yres + var->upper_margin + var->lower_margin +
		var->vsync_len;

	return (1000000000 / var->pixclock * 1000 + 500) / xtot / ytot;
}*/

static int intelfb_setcolreg(unsigned regno, unsigned red, unsigned green,
			unsigned blue, unsigned transp,
			struct fb_info *info)
{
	struct intelfb_par *par = info->par;
	struct drm_mode_set *modeset;

	list_for_each_entry(modeset, &par->mode_set_list, head) {
		struct drm_crtc *crtc = modeset->crtc;
		struct drm_framebuffer *fb = modeset->fb;

		if (regno > 255)
			return 1;

		if (fb->depth == 8) {
			intel_crtc_fb_gamma_set(crtc, red, green, blue, regno);
			return 0;
		}

		if (regno < 16) {
			switch (fb->depth) {
			case 15:
				fb->pseudo_palette[regno] = ((red & 0xf800) >> 1) |
					((green & 0xf800) >>  6) |
					((blue & 0xf800) >> 11);
				break;
			case 16:
				fb->pseudo_palette[regno] = (red & 0xf800) |
					((green & 0xfc00) >>  5) |
					((blue  & 0xf800) >> 11);
				break;
			case 24:
			case 32:
				fb->pseudo_palette[regno] = ((red & 0xff00) << 8) |
					(green & 0xff00) |
					((blue  & 0xff00) >> 8);
				break;
			}
		}
	}
	return 0;
}

static int intelfb_check_var(struct fb_var_screeninfo *var,
			struct fb_info *info)
{
	struct intelfb_par *par = info->par;
	struct intel_framebuffer *intel_fb = par->intel_fb;
	struct drm_framebuffer *fb = &intel_fb->base;
	int depth;

	if (var->pixclock == -1 || !var->pixclock)
		return -EINVAL;

	/* Need to resize the fb object !!! */
	if (var->xres > fb->width || var->yres > fb->height) {
		DRM_ERROR("Requested width/height is greater than current fb object %dx%d > %dx%d\n",var->xres,var->yres,fb->width,fb->height);
		DRM_ERROR("Need resizing code.\n");
		return -EINVAL;
	}

	switch (var->bits_per_pixel) {
	case 16:
		depth = (var->green.length == 6) ? 16 : 15;
		break;
	case 32:
		depth = (var->transp.length > 0) ? 32 : 24;
		break;
	default:
		depth = var->bits_per_pixel;
		break;
	}
		
	switch (depth) {
	case 8:
		var->red.offset = 0;
		var->green.offset = 0;
		var->blue.offset = 0;
		var->red.length = 8;
		var->green.length = 8;
		var->blue.length = 8;
		var->transp.length = 0;
		var->transp.offset = 0;
		break;
	case 15:
		var->red.offset = 10;
		var->green.offset = 5;
		var->blue.offset = 0;
		var->red.length = 5;
		var->green.length = 5;
		var->blue.length = 5;
		var->transp.length = 1;
		var->transp.offset = 15;
		break;
	case 16:
		var->red.offset = 11;
		var->green.offset = 5;
		var->blue.offset = 0;
		var->red.length = 5;
		var->green.length = 6;
		var->blue.length = 5;
		var->transp.length = 0;
		var->transp.offset = 0;
		break;
	case 24:
		var->red.offset = 16;
		var->green.offset = 8;
		var->blue.offset = 0;
		var->red.length = 8;
		var->green.length = 8;
		var->blue.length = 8;
		var->transp.length = 0;
		var->transp.offset = 0;
		break;
	case 32:
		var->red.offset = 16;
		var->green.offset = 8;
		var->blue.offset = 0;
		var->red.length = 8;
		var->green.length = 8;
		var->blue.length = 8;
		var->transp.length = 8;
		var->transp.offset = 24;
		break;
	default:
		return -EINVAL; 
	}

	return 0;
}

/* this will let fbcon do the mode init */
/* FIXME: take mode config lock? */
static int intelfb_set_par(struct fb_info *info)
{
	struct intelfb_par *par = info->par;
	struct drm_device *dev = par->dev;
	struct fb_var_screeninfo *var = &info->var;
	int found = 0;

	DRM_DEBUG("%d %d\n", var->xres, var->pixclock);


	if (var->pixclock != -1) {

		DRM_ERROR("PIXEL CLCOK SET\n");
#if 0
		struct intel_framebuffer *intel_fb = par->intel_fb;
		struct drm_framebuffer *fb = &intel_fb->base;
		struct drm_display_mode *drm_mode, *search_mode;
		struct drm_connector *connector = NULL;

		switch (var->bits_per_pixel) {
		case 16:
			fb->depth = (var->green.length == 6) ? 16 : 15;
			break;
		case 32:
			fb->depth = (var->transp.length > 0) ? 32 : 24;
			break;
		default:
			fb->depth = var->bits_per_pixel;
			break;
		}
		
		fb->bits_per_pixel = var->bits_per_pixel;
		
		info->fix.line_length = fb->pitch;
		info->fix.smem_len = info->fix.line_length * fb->height;
		info->fix.visual = (fb->depth == 8) ? FB_VISUAL_PSEUDOCOLOR : FB_VISUAL_TRUECOLOR;
		
		info->screen_size = info->fix.smem_len; /* ??? */
		/* reuse desired mode if possible */
		/* create a drm mode */
		drm_mode = drm_mode_create(dev);
		drm_mode->hdisplay = var->xres;
		drm_mode->hsync_start = drm_mode->hdisplay + var->right_margin;
		drm_mode->hsync_end = drm_mode->hsync_start + var->hsync_len;
		drm_mode->htotal = drm_mode->hsync_end + var->left_margin;
		drm_mode->vdisplay = var->yres;
		drm_mode->vsync_start = drm_mode->vdisplay + var->lower_margin;
		drm_mode->vsync_end = drm_mode->vsync_start + var->vsync_len;
		drm_mode->vtotal = drm_mode->vsync_end + var->upper_margin;
		drm_mode->clock = PICOS2KHZ(var->pixclock);
		drm_mode->vrefresh = drm_mode_vrefresh(drm_mode);
		drm_mode->flags = 0;
		drm_mode->flags |= var->sync & FB_SYNC_HOR_HIGH_ACT ? V_PHSYNC : V_NHSYNC;
		drm_mode->flags |= var->sync & FB_SYNC_VERT_HIGH_ACT ? V_PVSYNC : V_NVSYNC;
		
		drm_mode_set_name(drm_mode);
		drm_mode_set_crtcinfo(drm_mode, CRTC_INTERLACE_HALVE_V);
		
		found = 0;
		list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
			if (connector->encoder &&
			    connector->encoder->crtc == par->set.crtc){
				found = 1;
				break;
			}
		}
		
		/* no connector bound, bail */
		if (!found)
			return -EINVAL;
		
		found = 0;
		drm_mode_debug_printmodeline(drm_mode);
		list_for_each_entry(search_mode, &connector->modes, head) {
			drm_mode_debug_printmodeline(search_mode);
			if (drm_mode_equal(drm_mode, search_mode)) {
				drm_mode_destroy(dev, drm_mode);
				drm_mode = search_mode;
				found = 1;
				break;
			}
		}
		
		/* If we didn't find a matching mode that exists on our connector,
		 * create a new attachment for the incoming user specified mode
		 */
		if (!found) {
			if (par->our_mode) {
				/* this also destroys the mode */
				drm_mode_detachmode_crtc(dev, par->our_mode);
			}
			
			par->set.mode = drm_mode;
			par->our_mode = drm_mode;
			drm_mode_debug_printmodeline(drm_mode);
			/* attach mode */
			drm_mode_attachmode_crtc(dev, par->set.crtc, par->set.mode);
		} else {
			par->set.mode = drm_mode;
			if (par->our_mode)
				drm_mode_detachmode_crtc(dev, par->our_mode);
			par->our_mode = NULL;
		}
		return par->set.crtc->funcs->set_config(&par->set);
#endif
		return -EINVAL;
	} else {
		struct drm_mode_set *modeset;
		int ret;

		list_for_each_entry(modeset, &par->mode_set_list, head) {
			if (modeset->num_connectors) {
				ret = modeset->crtc->funcs->set_config(modeset);
				if (ret)
					return ret;
			}
		}
		return 0;
	}
}

#if 0
static void intelfb_copyarea(struct fb_info *info,
			const struct fb_copyarea *region)
{
	struct intelfb_par *par = info->par;
	struct drm_device *dev = par->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	u32 src_x1, src_y1, dst_x1, dst_y1, dst_x2, dst_y2, offset;
	u32 cmd, rop_depth_pitch, src_pitch;
	RING_LOCALS;

	cmd = XY_SRC_COPY_BLT_CMD;
	src_x1 = region->sx;
	src_y1 = region->sy;
	dst_x1 = region->dx;
	dst_y1 = region->dy;
	dst_x2 = region->dx + region->width;
	dst_y2 = region->dy + region->height;
	offset = par->fb->offset;
	rop_depth_pitch = BLT_ROP_GXCOPY | par->fb->pitch;
	src_pitch = par->fb->pitch;

	switch (par->fb->bits_per_pixel) {
	case 16:
		rop_depth_pitch |= BLT_DEPTH_16_565;
		break;
	case 32:
		rop_depth_pitch |= BLT_DEPTH_32;
		cmd |= XY_SRC_COPY_BLT_WRITE_ALPHA | XY_SRC_COPY_BLT_WRITE_RGB;
		break;
	}

	BEGIN_LP_RING(8);
	OUT_RING(cmd);
	OUT_RING(rop_depth_pitch);
	OUT_RING((dst_y1 << 16) | (dst_x1 & 0xffff));
	OUT_RING((dst_y2 << 16) | (dst_x2 & 0xffff));
	OUT_RING(offset);
	OUT_RING((src_y1 << 16) | (src_x1 & 0xffff));
	OUT_RING(src_pitch);
	OUT_RING(offset);
	ADVANCE_LP_RING();
}

#define ROUND_UP_TO(x, y)	(((x) + (y) - 1) / (y) * (y))
#define ROUND_DOWN_TO(x, y)	((x) / (y) * (y))

void intelfb_imageblit(struct fb_info *info, const struct fb_image *image)
{
	struct intelfb_par *par = info->par;
	struct drm_device *dev = par->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	u32 cmd, rop_pitch_depth, tmp;
	int nbytes, ndwords, pad;
	u32 dst_x1, dst_y1, dst_x2, dst_y2, offset, bg, fg;
	int dat, ix, iy, iw;
	int i, j;
	RING_LOCALS;

	/* size in bytes of a padded scanline */
	nbytes = ROUND_UP_TO(image->width, 16) / 8;

	/* Total bytes of padded scanline data to write out. */
	nbytes *= image->height;

	/*
	* Check if the glyph data exceeds the immediate mode limit.
	* It would take a large font (1K pixels) to hit this limit.
	*/
	if (nbytes > 128 || image->depth != 1)
		return cfb_imageblit(info, image);

	/* Src data is packaged a dword (32-bit) at a time. */
	ndwords = ROUND_UP_TO(nbytes, 4) / 4;

	/*
	* Ring has to be padded to a quad word. But because the command starts
	with 7 bytes, pad only if there is an even number of ndwords
	*/
	pad = !(ndwords % 2);

	DRM_DEBUG("imageblit %dx%dx%d to (%d,%d)\n", image->width,
		image->height, image->depth, image->dx, image->dy);
	DRM_DEBUG("nbytes: %d, ndwords: %d, pad: %d\n", nbytes, ndwords, pad);

	tmp = (XY_MONO_SRC_COPY_IMM_BLT & 0xff) + ndwords;
	cmd = (XY_MONO_SRC_COPY_IMM_BLT & ~0xff) | tmp;
	offset = par->fb->offset;
	dst_x1 = image->dx;
	dst_y1 = image->dy;
	dst_x2 = image->dx + image->width;
	dst_y2 = image->dy + image->height;
	rop_pitch_depth = BLT_ROP_GXCOPY | par->fb->pitch;

	switch (par->fb->bits_per_pixel) {
	case 8:
		rop_pitch_depth |= BLT_DEPTH_8;
		fg = image->fg_color;
		bg = image->bg_color;
		break;
	case 16:
		rop_pitch_depth |= BLT_DEPTH_16_565;
		fg = par->fb->pseudo_palette[image->fg_color];
		bg = par->fb->pseudo_palette[image->bg_color];
		break;
	case 32:
		rop_pitch_depth |= BLT_DEPTH_32;
		cmd |= XY_SRC_COPY_BLT_WRITE_ALPHA | XY_SRC_COPY_BLT_WRITE_RGB;
		fg = par->fb->pseudo_palette[image->fg_color];
		bg = par->fb->pseudo_palette[image->bg_color];
		break;
	default:
		DRM_ERROR("unknown depth %d\n", par->fb->bits_per_pixel);
		break;
	}
	
	BEGIN_LP_RING(8 + ndwords);
	OUT_RING(cmd);
	OUT_RING(rop_pitch_depth);
	OUT_RING((dst_y1 << 16) | (dst_x1 & 0xffff));
	OUT_RING((dst_y2 << 16) | (dst_x2 & 0xffff));
	OUT_RING(offset);
	OUT_RING(bg);
	OUT_RING(fg);
	ix = iy = 0;
	iw = ROUND_UP_TO(image->width, 8) / 8;
	while (ndwords--) {
		dat = 0;
		for (j = 0; j < 2; ++j) {
			for (i = 0; i < 2; ++i) {
				if (ix != iw || i == 0)
					dat |= image->data[iy*iw + ix++] << (i+j*2)*8;
			}
			if (ix == iw && iy != (image->height - 1)) {
				ix = 0;
				++iy;
			}
		}
		OUT_RING(dat);
	}
	if (pad)
		OUT_RING(MI_NOOP);
	ADVANCE_LP_RING();
}
#endif
static int intelfb_pan_display(struct fb_var_screeninfo *var,
				struct fb_info *info)
{
	struct intelfb_par *par = info->par;
	struct drm_mode_set *modeset;
	int ret = 0;
	DRM_DEBUG("\n");

	list_for_each_entry(modeset, &par->mode_set_list, head) {
		modeset->x = var->xoffset;
		modeset->y = var->yoffset;

		if (modeset->num_connectors) {
			ret = modeset->crtc->funcs->set_config(modeset);
		  
			if (!ret) {
				info->var.xoffset = var->xoffset;
				info->var.yoffset = var->yoffset;
			}
		}
	}

	return ret;
}

static struct fb_ops intelfb_ops = {
	.owner = THIS_MODULE,
	//.fb_open = intelfb_open,
	//.fb_read = intelfb_read,
	//.fb_write = intelfb_write,
	//.fb_release = intelfb_release,
	//.fb_ioctl = intelfb_ioctl,
	.fb_check_var = intelfb_check_var,
	.fb_set_par = intelfb_set_par,
	.fb_setcolreg = intelfb_setcolreg,
	.fb_fillrect = cfb_fillrect,
	.fb_copyarea = cfb_copyarea, //intelfb_copyarea,
	.fb_imageblit = cfb_imageblit, //intelfb_imageblit,
	.fb_pan_display = intelfb_pan_display,
};

/**
 * Curretly it is assumed that the old framebuffer is reused.
 *
 * LOCKING
 * caller should hold the mode config lock.
 *
 */
int intelfb_resize(struct drm_device *dev, struct drm_crtc *crtc)
{
	struct fb_info *info;
	struct drm_framebuffer *fb;
	struct drm_display_mode *mode = crtc->desired_mode;

	fb = crtc->fb;
	if (!fb)
		return 1;

	info = fb->fbdev;
	if (!info)
		return 1;

	if (!mode)
		return 1;

	info->var.xres = mode->hdisplay;
	info->var.right_margin = mode->hsync_start - mode->hdisplay;
	info->var.hsync_len = mode->hsync_end - mode->hsync_start;
	info->var.left_margin = mode->htotal - mode->hsync_end;
	info->var.yres = mode->vdisplay;
	info->var.lower_margin = mode->vsync_start - mode->vdisplay;
	info->var.vsync_len = mode->vsync_end - mode->vsync_start;
	info->var.upper_margin = mode->vtotal - mode->vsync_end;
	info->var.pixclock = 10000000 / mode->htotal * 1000 / mode->vtotal * 100;
	/* avoid overflow */
	info->var.pixclock = info->var.pixclock * 1000 / mode->vrefresh;

	return 0;
}
EXPORT_SYMBOL(intelfb_resize);

int intelfb_create(struct drm_device *dev, uint32_t fb_width, uint32_t fb_height, 
		   uint32_t surface_width, uint32_t surface_height,
		   struct intel_framebuffer **intel_fb_p)
{
	struct fb_info *info;
	struct intelfb_par *par;
	struct drm_framebuffer *fb;
	struct intel_framebuffer *intel_fb;
	struct drm_mode_fb_cmd mode_cmd;
	struct drm_buffer_object *fbo = NULL;
	struct device *device = &dev->pdev->dev; 
	int ret;

	mode_cmd.width = fb_width;/* crtc->desired_mode->hdisplay; */
	mode_cmd.height = fb_height;/* crtc->desired_mode->vdisplay; */
	
	mode_cmd.bpp = 32;
	mode_cmd.pitch = mode_cmd.width * ((mode_cmd.bpp + 1) / 8);
	mode_cmd.depth = 24;

	ret = drm_buffer_object_create(dev, mode_cmd.pitch * mode_cmd.height, 
					drm_bo_type_kernel,
					DRM_BO_FLAG_READ |
					DRM_BO_FLAG_WRITE |
					DRM_BO_FLAG_MEM_TT |
					DRM_BO_FLAG_MEM_VRAM |
					DRM_BO_FLAG_NO_EVICT,
					DRM_BO_HINT_DONT_FENCE, 0, 0,
					&fbo);
	if (ret || !fbo) {
		printk(KERN_ERR "failed to allocate framebuffer\n");
		return -EINVAL;
	}
	

	fb = intel_user_framebuffer_create(dev, NULL, &mode_cmd);
	if (!fb) {
		drm_bo_usage_deref_unlocked(&fbo);
		DRM_ERROR("failed to allocate fb.\n");
		return -EINVAL;
	}

	intel_fb = to_intel_framebuffer(fb);
	*intel_fb_p = intel_fb;

	intel_fb->bo = fbo;

	info = framebuffer_alloc(sizeof(struct intelfb_par), device);
	if (!info)
		return -EINVAL;

	par = info->par;

	strcpy(info->fix.id, "inteldrmfb");
	info->fix.type = FB_TYPE_PACKED_PIXELS;
	info->fix.visual = FB_VISUAL_TRUECOLOR;
	info->fix.type_aux = 0;
	info->fix.xpanstep = 1; /* doing it in hw */
	info->fix.ypanstep = 1; /* doing it in hw */
	info->fix.ywrapstep = 0;
	info->fix.accel = FB_ACCEL_I830;
	info->fix.type_aux = 0;

	info->flags = FBINFO_DEFAULT;

	info->fbops = &intelfb_ops;

	info->fix.line_length = fb->pitch;
	info->fix.smem_start = intel_fb->bo->offset + dev->mode_config.fb_base;
	info->fix.smem_len = info->fix.line_length * fb->height;

	info->flags = FBINFO_DEFAULT;

 	ret = drm_bo_kmap(intel_fb->bo, 0, intel_fb->bo->num_pages, &intel_fb->kmap);
	if (ret)
		DRM_ERROR("error mapping fb: %d\n", ret);

 	info->screen_base = intel_fb->kmap.virtual;
	info->screen_size = info->fix.smem_len; /* FIXME */
	info->pseudo_palette = fb->pseudo_palette;
	info->var.xres_virtual = surface_width;
	info->var.yres_virtual = surface_height;
	info->var.bits_per_pixel = fb->bits_per_pixel;
	info->var.xoffset = 0;
	info->var.yoffset = 0;
	info->var.activate = FB_ACTIVATE_NOW;
	info->var.height = -1;
	info->var.width = -1;

	info->var.xres = fb_width;
	info->var.yres = fb_height;

 	if (IS_I9XX(dev)) {
 		info->fix.mmio_start = pci_resource_start(dev->pdev, 0);
 		info->fix.mmio_len = pci_resource_len(dev->pdev, 0);
 	} else {
 		info->fix.mmio_start = pci_resource_start(dev->pdev, 1);
 		info->fix.mmio_len = pci_resource_len(dev->pdev, 1);
 	}

	info->pixmap.size = 64*1024;
	info->pixmap.buf_align = 8;
	info->pixmap.access_align = 32;
	info->pixmap.flags = FB_PIXMAP_SYSTEM;
	info->pixmap.scan_align = 1;

	DRM_DEBUG("fb depth is %d\n", fb->depth);
	DRM_DEBUG("   pitch is %d\n", fb->pitch);
	switch(fb->depth) {
	case 8:
		info->var.red.offset = 0;
		info->var.green.offset = 0;
		info->var.blue.offset = 0;
		info->var.red.length = 8; /* 8bit DAC */
		info->var.green.length = 8;
		info->var.blue.length = 8;
		info->var.transp.offset = 0;
		info->var.transp.length = 0;
		break;
 	case 15:
		info->var.red.offset = 10;
		info->var.green.offset = 5;
		info->var.blue.offset = 0;
		info->var.red.length = 5;
		info->var.green.length = 5;
		info->var.blue.length = 5;
		info->var.transp.offset = 15;
		info->var.transp.length = 1;
		break;
	case 16:
		info->var.red.offset = 11;
		info->var.green.offset = 5;
		info->var.blue.offset = 0;
		info->var.red.length = 5;
		info->var.green.length = 6;
		info->var.blue.length = 5;
		info->var.transp.offset = 0;
 		break;
	case 24:
		info->var.red.offset = 16;
		info->var.green.offset = 8;
		info->var.blue.offset = 0;
		info->var.red.length = 8;
		info->var.green.length = 8;
		info->var.blue.length = 8;
		info->var.transp.offset = 0;
		info->var.transp.length = 0;
		break;
	case 32:
		info->var.red.offset = 16;
		info->var.green.offset = 8;
		info->var.blue.offset = 0;
		info->var.red.length = 8;
		info->var.green.length = 8;
		info->var.blue.length = 8;
		info->var.transp.offset = 24;
		info->var.transp.length = 8;
		break;
	default:
		break;
	}

	fb->fbdev = info;

	INIT_LIST_HEAD(&par->mode_set_list);

	par->intel_fb = intel_fb;

	/* To allow resizeing without swapping buffers */
	printk("allocated %dx%d fb: 0x%08lx, bo %p\n", intel_fb->base.width,
	       intel_fb->base.height, intel_fb->bo->offset, fbo);

	return 0;
}

int intelfb_probe(struct drm_device *dev)
{
	struct fb_info *info;
	struct intelfb_par *par;
	struct device *device = &dev->pdev->dev; 
	struct intel_framebuffer *intel_fb;
	struct drm_mode_set *modeset;
	struct drm_crtc *crtc;
	struct drm_connector *connector;
	int ret;
	int crtc_count = 0, i;
	unsigned int fb_width = (unsigned)-1, fb_height = (unsigned)-1;
	unsigned int surface_width = 0, surface_height = 0;

	DRM_DEBUG("\n");

	list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
		if (crtc->desired_mode) {
			if (crtc->desired_mode->hdisplay < fb_width)
				fb_width = crtc->desired_mode->hdisplay;

			if (crtc->desired_mode->vdisplay < fb_height)
				fb_height = crtc->desired_mode->vdisplay;

			if (crtc->desired_mode->hdisplay > surface_width)
				surface_width = crtc->desired_mode->hdisplay;

			if (crtc->desired_mode->vdisplay > surface_height)
				surface_height = crtc->desired_mode->vdisplay;
		}
		crtc_count++;
	}

	if (fb_width == -1 || fb_height == -1) {
		return -EINVAL;
	}

	DRM_DEBUG("here %d %d %d %d\n", fb_width, fb_height, surface_width, surface_height);
	ret = intelfb_create(dev, fb_width, fb_height, surface_width, surface_height, &intel_fb);
	if (ret)
		return -EINVAL;

	DRM_DEBUG("here %p\n", intel_fb);
	info = intel_fb->base.fbdev;
	par = info->par;

	DRM_DEBUG("crtc count is %d\n", crtc_count);
	/* make up a couple of config sets */
	for (i = 0; i < crtc_count; i++) {
		int conn_count = 0;

		modeset = kzalloc(sizeof(struct drm_mode_set), GFP_KERNEL);
		modeset->fb = &intel_fb->base;

		list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
			struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
			if (intel_crtc->pipe == i)
				modeset->crtc = crtc;
		}


		DRM_DEBUG("1\n");
		/* find out how many connectors are on this */
		list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
			if (connector->encoder)
				if (connector->encoder->crtc == modeset->crtc)
					conn_count++;
		}

		list_add_tail(&modeset->head, &par->mode_set_list);

		if (!conn_count)
			continue;
		
		DRM_DEBUG("cc %d\n", conn_count);
		modeset->connectors = kcalloc(conn_count, sizeof(struct drm_connector *), GFP_KERNEL);
		if (!modeset->connectors) {
			ret = -ENOMEM;
			goto fail;
		}

		modeset->num_connectors = conn_count;
		
		conn_count = 0;
		list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
			if (connector->encoder)
				if (connector->encoder->crtc == modeset->crtc)
					modeset->connectors[conn_count++] = connector;
		}
		modeset->mode = modeset->crtc->desired_mode;
	}
       
	info->var.pixclock = -1;
#if 0
	info->var.right_margin = mode->hsync_start - mode->hdisplay;
	info->var.hsync_len = mode->hsync_end - mode->hsync_start;
	info->var.left_margin = mode->htotal - mode->hsync_end;
	info->var.lower_margin = mode->vsync_start - mode->vdisplay;
	info->var.vsync_len = mode->vsync_end - mode->vsync_start;
	info->var.upper_margin = mode->vtotal - mode->vsync_end;
	info->var.pixclock = KHZ2PICOS(mode->clock);

	if (mode->flags & V_PHSYNC)
		info->var.sync |= FB_SYNC_HOR_HIGH_ACT;

	if (mode->flags & V_PVSYNC)
		info->var.sync |= FB_SYNC_VERT_HIGH_ACT;

	if (mode->flags & V_INTERLACE)
		info->var.vmode = FB_VMODE_INTERLACED;
	else if (mode->flags & V_DBLSCAN)
		info->var.vmode = FB_VMODE_DOUBLE;
	else
		info->var.vmode = FB_VMODE_NONINTERLACED;

#endif

	if (register_framebuffer(info) < 0)
		return -EINVAL;

	printk(KERN_INFO "fb%d: %s frame buffer device\n", info->node,
		info->fix.id);
	return 0;
fail:
	/*  TODO */
	return ret;
}
EXPORT_SYMBOL(intelfb_probe);

int intelfb_remove(struct drm_device *dev, struct drm_framebuffer *fb)
{
	struct fb_info *info;
	struct intel_framebuffer *intel_fb = to_intel_framebuffer(fb);

	if (!fb)
		return -EINVAL;

	info = fb->fbdev;
	
	if (info) {
		unregister_framebuffer(info);
		drm_bo_kunmap(&intel_fb->kmap);
		drm_bo_usage_deref_unlocked(&intel_fb->bo);
		framebuffer_release(info);
	}
	return 0;
}
EXPORT_SYMBOL(intelfb_remove);
MODULE_LICENSE("GPL");