From 3001c232d14a07153c36a0722e196041d6536d30 Mon Sep 17 00:00:00 2001 From: Tobias Jakobi Date: Sun, 1 Jun 2014 18:04:05 +0200 Subject: [PATCH] exynos: fix G2D_DOUBLE_TO_FIXED for non-integer input The hardware accepts scaling factors formatted in a fixed-point format. The current macro casts to integer first, then multiplies by the fp conversion factor. This does not make any sense. In particular, truly 'fractional' inputs, like 1.5, won't work that way. Signed-off-by: Tobias Jakobi Signed-off-by: Inki Dae --- exynos/fimg2d.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exynos/fimg2d.h b/exynos/fimg2d.h index 1aac378d..4785e2f0 100644 --- a/exynos/fimg2d.h +++ b/exynos/fimg2d.h @@ -25,7 +25,7 @@ #define G2D_MAX_CMD_LIST_NR 64 #define G2D_PLANE_MAX_NR 2 -#define G2D_DOUBLE_TO_FIXED(d) ((unsigned int)(d) * 65536.0) +#define G2D_DOUBLE_TO_FIXED(d) ((unsigned int)((d) * 65536.0)) enum e_g2d_color_mode { /* COLOR FORMAT */