From 473e2d2e67fec52503fe02b7a0ca26c4cd8fdbb6 Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Thu, 6 Sep 2018 16:14:07 +0100 Subject: [PATCH] intel: annotate the intel genx helpers as private They're used internally and never meant to be part of the API. Add the drm_private notation, which should resolve that. v2: (Rodrigo) Add missing include. v3: (Rodrigo) Keep includes grouped per Eric suggestion. Cc: Eric Engestrom Cc: Lucas De Marchi Cc: Chris Wilson Cc: Rodrigo Vivi Fixes: 4e81d4f9c9b ("intel: add generic functions to check PCI ID") Signed-off-by: Emil Velikov Acked-by: Lucas De Marchi Signed-off-by: Rodrigo Vivi Reviewed-by: Eric Engestrom --- intel/intel_chipset.c | 4 ++-- intel/intel_chipset.h | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/intel/intel_chipset.c b/intel/intel_chipset.c index d5c33cc5..5aa4a2f2 100644 --- a/intel/intel_chipset.c +++ b/intel/intel_chipset.c @@ -44,7 +44,7 @@ static const struct pci_device { INTEL_SKL_IDS(9), }; -bool intel_is_genx(unsigned int devid, int gen) +drm_private bool intel_is_genx(unsigned int devid, int gen) { const struct pci_device *p, *pend = pciids + sizeof(pciids) / sizeof(pciids[0]); @@ -66,7 +66,7 @@ bool intel_is_genx(unsigned int devid, int gen) return false; } -bool intel_get_genx(unsigned int devid, int *gen) +drm_private bool intel_get_genx(unsigned int devid, int *gen) { const struct pci_device *p, *pend = pciids + sizeof(pciids) / sizeof(pciids[0]); diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h index 9b1e64f1..5db207cc 100644 --- a/intel/intel_chipset.h +++ b/intel/intel_chipset.h @@ -329,9 +329,10 @@ /* New platforms use kernel pci ids */ #include +#include -bool intel_is_genx(unsigned int devid, int gen); -bool intel_get_genx(unsigned int devid, int *gen); +drm_private bool intel_is_genx(unsigned int devid, int gen); +drm_private bool intel_get_genx(unsigned int devid, int *gen); #define IS_GEN9(devid) intel_is_genx(devid, 9) #define IS_GEN10(devid) intel_is_genx(devid, 10)