geemili
/
drm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm mode: fix drmIoctl wrapper 

Both drmIoctl and ioctl define second argument as unigned long.

Debugging/tracing tools (like strace or valgrind) on 64-bit machines see
different request value for ioctls with 32nd bit set, because casting
signed int to unsigned long extends 32nd bit to upper word, so 0x80000000
becomes 0xFFFFFFFF80000000)

Nobody noticed because higher 32 bits are chopped off on their way to kernel.
main
Marcin Slusarz 2011-06-05 18:53:16 +02:00
parent 2acaf160df
commit 763b618d55
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
xf86drmMode.c
View File

@ -52,7 +52,7 @@
#define U642VOID(x) ((void *)(unsigned long)(x)) #define U642VOID(x) ((void *)(unsigned long)(x))
#define VOID2U64(x) ((uint64_t)(unsigned long)(x)) #define VOID2U64(x) ((uint64_t)(unsigned long)(x))
static inline int DRM_IOCTL(int fd, int cmd, void *arg) static inline int DRM_IOCTL(int fd, unsigned long cmd, void *arg)
{ {
int ret = drmIoctl(fd, cmd, arg); int ret = drmIoctl(fd, cmd, arg);
return ret < 0 ? -errno : ret; return ret < 0 ? -errno : ret;