geemili
/
drm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

exynos/fimg2d: remove default case from g2d_get_blend_op() 

We now validate the blending mode via g2d_validate_mode()
prior to feeding it to g2d_get_blend_op().

Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
main
Tobias Jakobi 2015-09-08 17:22:30 +02:00 committed by Emil Velikov
parent e3c97d1a24
commit 76d1c6b157
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
exynos/exynos_fimg2d.c
View File

@ -64,6 +64,11 @@ static unsigned int g2d_get_blend_op(enum e_g2d_op op)
val.val = 0;
/*
* The switch statement is missing the default branch since
* we assume that the caller checks the blending operation
* via g2d_validate_blending_op() first.
*/
switch (op) {
case G2D_OP_CLEAR:
case G2D_OP_DISJOINT_CLEAR:
@ -91,11 +96,6 @@ static unsigned int g2d_get_blend_op(enum e_g2d_op op)
SET_BF(val, G2D_COEFF_MODE_SRC_ALPHA, 0, 0, 0,
G2D_COEFF_MODE_SRC_ALPHA, 1, 0, 0);
break;
default:
fprintf(stderr, "Not support operation(%d).\n", op);
SET_BF(val, G2D_COEFF_MODE_ONE, 0, 0, 0, G2D_COEFF_MODE_ZERO,
0, 0, 0);
break;
}
return val.val;