From 8d893e49ec35905a3718c565ec56c21d76dc745c Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Thu, 19 Apr 2007 09:43:46 +1000 Subject: [PATCH] backout SDVO control bus check and comment why this is a bad idea --- linux-core/intel_sdvo.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/linux-core/intel_sdvo.c b/linux-core/intel_sdvo.c index f004c766..507b0f5e 100644 --- a/linux-core/intel_sdvo.c +++ b/linux-core/intel_sdvo.c @@ -297,14 +297,14 @@ int intel_sdvo_get_pixel_multiplier(struct drm_display_mode *mode) return 4; } -static bool intel_sdvo_set_control_bus_switch(struct drm_output *output, u8 target) +/** + * Don't check status code from this as it switches the bus back to the + * SDVO chips which defeats the purpose of doing a bus switch in the first + * place. + */ +void intel_sdvo_set_control_bus_switch(struct drm_output *output, u8 target) { - u8 status; - intel_sdvo_write_cmd(output, SDVO_CMD_SET_CONTROL_BUS_SWITCH, &target, 1); - status = intel_sdvo_read_response(output, NULL, 0); - - return (status == SDVO_CMD_STATUS_SUCCESS); } static bool intel_sdvo_set_target_input(struct drm_output *output, bool target_0, bool target_1)