geemili
/
drm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

freedreno: remove dead error path 

`pipe` cannot be non-null, so the label reduces to a simple return.
Then, there is no point initialising `pipe` just to overwrite it before
anyone reads it.

Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: Rob Clark <robdclark@gmail.com>
main
Eric Engestrom 2017-07-30 21:27:38 +01:00 committed by Eric Engestrom
parent e2b6785c5a
commit ac2b806c45
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
freedreno/freedreno_pipe.c
View File

@ -36,18 +36,18 @@
struct fd_pipe * struct fd_pipe *
fd_pipe_new(struct fd_device *dev, enum fd_pipe_id id) fd_pipe_new(struct fd_device *dev, enum fd_pipe_id id)
{ {
struct fd_pipe *pipe = NULL; struct fd_pipe *pipe;
uint64_t val; uint64_t val;
if (id > FD_PIPE_MAX) { if (id > FD_PIPE_MAX) {
ERROR_MSG("invalid pipe id: %d", id); ERROR_MSG("invalid pipe id: %d", id);
goto fail; return NULL;
} }
pipe = dev->funcs->pipe_new(dev, id); pipe = dev->funcs->pipe_new(dev, id);
if (!pipe) { if (!pipe) {
ERROR_MSG("allocation failed"); ERROR_MSG("allocation failed");
goto fail; return NULL;
} }
pipe->dev = dev; pipe->dev = dev;
@ -57,10 +57,6 @@ fd_pipe_new(struct fd_device *dev, enum fd_pipe_id id)
pipe->gpu_id = val; pipe->gpu_id = val;
return pipe; return pipe;
fail:
if (pipe)
fd_pipe_del(pipe);
return NULL;
} }
void fd_pipe_del(struct fd_pipe *pipe) void fd_pipe_del(struct fd_pipe *pipe)