geemili
/
drm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused 3rd parameter to open(2) 

The 3rd parameter is only used with the O_CREAT flag

Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
main
Matthieu Herrb 2021-10-26 19:00:22 +02:00 committed by Matt Turner
parent a64a176cfd
commit cf54ebf6cf
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/drmdevice.c
View File

@ -142,7 +142,7 @@ main(void)
for (int j = 0; j < DRM_NODE_MAX; j++) { for (int j = 0; j < DRM_NODE_MAX; j++) {
if (devices[i]->available_nodes & 1 << j) { if (devices[i]->available_nodes & 1 << j) {
printf("--- Opening device node %s ---\n", devices[i]->nodes[j]); printf("--- Opening device node %s ---\n", devices[i]->nodes[j]);
fd = open(devices[i]->nodes[j], O_RDONLY | O_CLOEXEC, 0); fd = open(devices[i]->nodes[j], O_RDONLY | O_CLOEXEC);
if (fd < 0) { if (fd < 0) {
printf("Failed - %s (%d)\n", strerror(errno), errno); printf("Failed - %s (%d)\n", strerror(errno), errno);
continue; continue;

10
xf86drm.c
View File

@ -849,7 +849,7 @@ wait_for_udev:
} }
#endif #endif
fd = open(buf, O_RDWR | O_CLOEXEC, 0); fd = open(buf, O_RDWR | O_CLOEXEC);
drmMsg("drmOpenDevice: open result is %d, (%s)\n", drmMsg("drmOpenDevice: open result is %d, (%s)\n",
fd, fd < 0 ? strerror(errno) : "OK"); fd, fd < 0 ? strerror(errno) : "OK");
if (fd >= 0) if (fd >= 0)
@ -869,7 +869,7 @@ wait_for_udev:
chmod(buf, devmode); chmod(buf, devmode);
} }
} }
fd = open(buf, O_RDWR | O_CLOEXEC, 0); fd = open(buf, O_RDWR | O_CLOEXEC);
drmMsg("drmOpenDevice: open result is %d, (%s)\n", drmMsg("drmOpenDevice: open result is %d, (%s)\n",
fd, fd < 0 ? strerror(errno) : "OK"); fd, fd < 0 ? strerror(errno) : "OK");
if (fd >= 0) if (fd >= 0)
@ -907,7 +907,7 @@ static int drmOpenMinor(int minor, int create, int type)
return -EINVAL; return -EINVAL;
sprintf(buf, dev_name, DRM_DIR_NAME, minor); sprintf(buf, dev_name, DRM_DIR_NAME, minor);
if ((fd = open(buf, O_RDWR | O_CLOEXEC, 0)) >= 0) if ((fd = open(buf, O_RDWR | O_CLOEXEC)) >= 0)
return fd; return fd;
return -errno; return -errno;
} }
@ -1135,7 +1135,7 @@ static int drmOpenByName(const char *name, int type)
int retcode; int retcode;
sprintf(proc_name, "/proc/dri/%d/name", i); sprintf(proc_name, "/proc/dri/%d/name", i);
if ((fd = open(proc_name, O_RDONLY, 0)) >= 0) { if ((fd = open(proc_name, O_RDONLY)) >= 0) {
retcode = read(fd, buf, sizeof(buf)-1); retcode = read(fd, buf, sizeof(buf)-1);
close(fd); close(fd);
if (retcode) { if (retcode) {
@ -3892,7 +3892,7 @@ static int drmParsePciDeviceInfo(int maj, int min,
if (get_sysctl_pci_bus_info(maj, min, &info) != 0) if (get_sysctl_pci_bus_info(maj, min, &info) != 0)
return -EINVAL; return -EINVAL;
fd = open("/dev/pci", O_RDONLY, 0); fd = open("/dev/pci", O_RDONLY);
if (fd < 0) if (fd < 0)
return -errno; return -errno;