geemili
/
drm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

modesetting: fix memory leak and misallocation

main
Dave Airlie 2008-02-21 15:58:56 +10:00
parent cdad850ebc
commit fad1db2d73
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
linux-core/drm_crtc.c
View File

@ -1092,7 +1092,8 @@ int drm_crtc_set_config(struct drm_crtc *crtc, struct drm_mode_crtc *crtc_info,
struct drm_output *output; struct drm_output *output;
int count = 0, ro; int count = 0, ro;
save_crtcs = kzalloc(dev->mode_config.num_crtc * sizeof(struct drm_crtc *), GFP_KERNEL); /* this is meant to be num_output not num_crtc */
save_crtcs = kzalloc(dev->mode_config.num_output * sizeof(struct drm_crtc *), GFP_KERNEL);
if (!save_crtcs) if (!save_crtcs)
return -ENOMEM; return -ENOMEM;
@ -1663,10 +1664,10 @@ int drm_mode_setcrtc(struct drm_device *dev,
} }
} }
/* What happens to output_set, leak? */
ret = drm_crtc_set_config(crtc, crtc_req, mode, output_set, fb); ret = drm_crtc_set_config(crtc, crtc_req, mode, output_set, fb);
out: out:
kfree(output_set);
mutex_unlock(&dev->mode_config.mutex); mutex_unlock(&dev->mode_config.mutex);
return ret; return ret;
} }